Anyone who gives a blanket statement of "stay" or "switch to _____" is full of it. There is no one size fits all answer, it just depends on your personal situation and how much risk you're willing to subject yourself to.
Example. I was a long time regional FO at a place that didn't have much of a future in terms of growth, upgrades, etc. But at the time I was flying under a pretty solid contract (as far as regionals go), I was driving to work, and I really enjoyed who I was working with. I was young, so I was willing to take the chance of sticking around for a few years and seeing where things went. It wasn't until my base closed and I was stuck commuting that I started to get the "I need to get out of here" feeling.
I applied and was hired as a street captain at PSA. In the end I didn't take the job as I didn't get the best feeling from the recruiter. It might have been a better place to hang out than XJT, but through talking to people who did the street captain thing I think I would have been pretty miserable.
Thankfully I got a lucky bounce and was able to move on, but I think I was able to show that both staying or going would have had plusses and minuses. It just depends what is important at the time.