Please review:
https://pilot-protection-services.aopa.org/PPS-Plan-Details.aspx
The benefits provided are more comprehensive than this discussion has narrowed its focus to.
You say "invest" the $99/year, but assuming your suggested investment is in something reasonably safe, after the aforementioned 40 years, you've lost, at most, a potential $8k in "investment" income... and that will probably barely offset inflation.
What you don't acknowledge is that we (in the part 91, 119, 135, 141, or GA worlds) have no protection if we should have an event which threatens our medical certificate, pilot certificate, etc. We also have no source of document review, so when we sign a contract—any contract, including an employment contract—we either have to do our own legal review or hire a lawyer for $hundreds. Considering that jobs in these categories aren't considered "career-long" positions, but can certainly come with all sorts of nasty contract gotchas such as training contracts, etc., such review would add up very quickly. Further, buying or selling an airplane, signing a tiedown contract, dealing with issues from a student that comes back to haunt you, dealing with tax issues or even asking questions about the same can all set you back a tremendous amount.
Will all of this apply to every pilot? Certainly not. It's a risk-reward proposition that's best determined on an individual basis. However, I feel much better knowing that I have a legal service "on contract" to provide a certain amount of document review, clarification, and so on., and that I have a first point of contact for a certificate action (medical, airman, or instructor) who is on my side and already affiliated with—and ready to defend—me.
-Fox